mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Review Request 55604: CMake: Transitioned Libprocess to automatic source grouping.
Date Tue, 17 Jan 2017 06:32:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55604/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Bugs: MESOS-3542
    https://issues.apache.org/jira/browse/MESOS-3542


Repository: mesos


Description
-------

Libprocess currently manually groups its source code by folder in order
to present the source nicely in IDEs like XCode and Visual Studio.

With the recently-introduced CMake function, `GROUP_SOURCE`, this
process is automated away. This commit will remove these manual groups
and replace it with a call to this function.


Diffs
-----

  3rdparty/libprocess/cmake/ProcessConfigure.cmake 873f41d844faa0d442f77411e94314a89be5f046

  3rdparty/libprocess/src/CMakeLists.txt 60f0e76dfd237d9a12a366b413802d1a96892b55 
  3rdparty/libprocess/src/tests/CMakeLists.txt 0b2660cb16f5d8d8dc66e6995061d0b832182351 

Diff: https://reviews.apache.org/r/55604/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message