mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 55576: Fixes FutureTest.After3 flakiness.
Date Mon, 16 Jan 2017 16:47:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55576/#review161752
-----------------------------------------------------------



Patch looks great!

Reviews applied: [55576]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos ReviewBot


On Jan. 16, 2017, 2:34 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55576/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 2:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-6907
>     https://issues.apache.org/jira/browse/MESOS-6907
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a flakiness in `FutureTest.After3` related a timer not being
> destroyed on time by libprocess before verifying the expectations.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/future_tests.cpp 380755f9a2329d548969cfb2332c79aacbf7fff2

> 
> Diff: https://reviews.apache.org/r/55576/diff/
> 
> 
> Testing
> -------
> 
> ```sh
> # Put the machine under stress.
> $ stress -c 4 -t 2600 -d 2 -i 2 &
> $ ./${MESOS_SRC_ROOT}/build/3rdparty/libprocess/libprocess-tests \
>       --gtest_filter="FutureTest.After3" --gtest_repeat=1000000 --gtest_break_on_failure
> $ ./${MESOS_SRC_ROOT}/build/build/src/mesos-tests
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message