mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".
Date Mon, 16 Jan 2017 15:39:13 GMT


> On Jan. 13, 2017, 12:33 p.m., Gastón Kleiman wrote:
> > src/launcher/executor.cpp, line 82
> > <https://reviews.apache.org/r/55456/diff/1/?file=1603827#file1603827line82>
> >
> >     According to our style guide, this should be the first include =)

Good catch!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55456/#review161512
-----------------------------------------------------------


On Jan. 12, 2017, 1:19 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55456/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2017, 1:19 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa 
> 
> Diff: https://reviews.apache.org/r/55456/diff/
> 
> 
> Testing
> -------
> 
> None: not a functional change
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message