mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 55541: Replaced (another) recursive implementation with process::loop.
Date Mon, 16 Jan 2017 09:10:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55541/#review161696
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/http.cpp (line 967)
<https://reviews.apache.org/r/55541/#comment233008>

    Please rename `reader` to something else to avoid shadowing `reader` defined at L953.
`requestReader`?



3rdparty/libprocess/src/http.cpp (lines 989 - 990)
<https://reviews.apache.org/r/55541/#comment233009>

    I see that you simply restore the previous behaviour here, but still, I don't see how
we can enter the `.onDiscarded()` branch.


- Alexander Rukletsov


On Jan. 14, 2017, 10:32 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55541/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2017, 10:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Benjamin Mahler, and Kevin
Klues.
> 
> 
> Bugs: MESOS-6913
>     https://issues.apache.org/jira/browse/MESOS-6913
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced (another) recursive implementation with process::loop.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/http.cpp 8895f0cfadf1cca9714fc7110ed0914e3db18983 
> 
> Diff: https://reviews.apache.org/r/55541/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message