mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <>
Subject Re: Review Request 55252: Refactored `roles()` and `getRoles()` to reuse common logic.
Date Mon, 16 Jan 2017 06:30:07 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 16, 2017, 2:30 p.m.)

Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.


rebase and squashed previous patch into this one to make the review more readable.

Summary (updated)

Refactored `roles()` and `getRoles()` to reuse common logic.

Bugs: MESOS-6855

Repository: mesos

Description (updated)

Some common logic are extracted into two new methods `filterRoles`
and `_getRoles`, which can be reused by both v0 and v1 APIs. This
is a step toward adding 'roles' section into '/state' endpoint.

Diffs (updated)

  src/master/http.cpp a44621f39cb059e654a56f57f75b38947f3a4230 
  src/master/master.hpp 44f4fecb1fbe8bebf830990a59a5462338e6e004 




Jay Guo

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message