mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 55271: Disallow multi-role frameworks to change their roles.
Date Sat, 14 Jan 2017 21:04:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55271/#review161648
-----------------------------------------------------------




src/master/master.cpp (lines 2473 - 2506)
<https://reviews.apache.org/r/55271/#comment232920>

    Can you move this right after 2448 to group the logic related with role?



src/master/master.cpp (line 2490)
<https://reviews.apache.org/r/55271/#comment232921>

    I think that you may want to 
    ```
    #include <stout/hashset.hpp>
    ```



src/tests/master_validation_tests.cpp (line 2616)
<https://reviews.apache.org/r/55271/#comment232922>

    How about s/RejectRolesChange/RejectRolesChangeWithMutiRole


- Guangya Liu


On 一月 12, 2017, 3:32 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55271/
> -----------------------------------------------------------
> 
> (Updated 一月 12, 2017, 3:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
> 
> 
> Bugs: MESOS-6631
>     https://issues.apache.org/jira/browse/MESOS-6631
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We currently do not allow `MULTI_ROLE` frameworks to change their
> roles. This restriction will be lifted later.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040 
>   src/tests/master_validation_tests.cpp e5d55e03648cb218d42adc594d6fa7d40ea9bcbb 
> 
> Diff: https://reviews.apache.org/r/55271/diff/
> 
> 
> Testing
> -------
> 
> Tested on various Linux configurations in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message