> On Jan. 13, 2017, 1 p.m., Benjamin Bannier wrote:
> > support/mesos-tidy/entrypoint.sh, line 27
> > <https://reviews.apache.org/r/55489/diff/2/?file=1604531#file1604531line27>
> >
> > Left over debug tooling?
>
> Michael Park wrote:
> I use this a bunch of times below.
I think we should either make this accessible to callers by passing in the values via `mesos-tidy.sh`
(like is done for e.g., `CHECKS`), or just directly use `$(nproc)`. As currently written the
variable provides no direct benefit (but maybe for occasional debugging where one might set
`NPROC` to so value by patching this file).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55489/#review161500
-----------------------------------------------------------
On Jan. 13, 2017, 10:59 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55489/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 10:59 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used CMake to generate the compilation database instead.
>
>
> Diffs
> -----
>
> support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7
> support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
> support/mesos-tidy/entrypoint.sh 72872375f3e5ad19bc75949f9e3db14d6068f9b6
>
> Diff: https://reviews.apache.org/r/55489/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
|