mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 55509: Validate the StatusUpdate UUID in Master::statusUpdate.
Date Fri, 13 Jan 2017 23:35:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55509/#review161617
-----------------------------------------------------------


Fix it, then Ship it!




Sorry missed a few minor things.


src/master/master.cpp (line 5848)
<https://reviews.apache.org/r/55509/#comment232876>

    Sorry forgot to mention that 
    
    s/uuid_/uuid/ (no need for it, the other instance in this file has a method argument `uuid`
already)



src/master/master.cpp (line 5852)
<https://reviews.apache.org/r/55509/#comment232877>

    s/":"/": "/


- Jiang Yan Xu


On Jan. 13, 2017, 3:29 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55509/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2017, 3:29 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6920
>     https://issues.apache.org/jira/browse/MESOS-6920
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To be consistent with Master::statusUpdateAcknowledgement(), validate
> that the UUID in the StatusUpdate message is acceptable to the
> UUID::fromBytes() parser.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040 
> 
> Diff: https://reviews.apache.org/r/55509/diff/
> 
> 
> Testing
> -------
> 
> Make check (Fedora 25). Manual testing with a handmade StatusUpdate message.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message