mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 55446: Added common validation for IDs.
Date Fri, 13 Jan 2017 19:54:02 GMT


> On Jan. 12, 2017, 1:43 p.m., James Peach wrote:
> > src/common/validation.hpp, line 34
> > <https://reviews.apache.org/r/55446/diff/1/?file=1603765#file1603765line34>
> >
> >     Since this is never used externally, consider making it a local static helper/

This is used externally.


> On Jan. 12, 2017, 1:43 p.m., James Peach wrote:
> > src/common/validation.hpp, line 18
> > <https://reviews.apache.org/r/55446/diff/1/?file=1603765#file1603765line18>
> >
> >     Should this be `__COMMON_VALIDATION_HPP__`?

It's not a requirement to match the file path but since I am putting the methods in the `common`
namespace I guess I could use `__COMMON_VALIDATION_HPP__` here.

Another point is that perhaps we could move *some* of these (as a TODO) to `<mesos>/include/mesos/validation.hpp`
for which we could use `__VALIDATION_HPP__`.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55446/#review161426
-----------------------------------------------------------


On Jan. 12, 2017, 1:46 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55446/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2017, 1:46 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, James Peach, and Joseph Wu.
> 
> 
> Bugs: MESOS-6866
>     https://issues.apache.org/jira/browse/MESOS-6866
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - The common validation logic is shared by the master and the agent.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c 
>   src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c 
>   src/common/validation.hpp PRE-CREATION 
>   src/common/validation.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55446/diff/
> 
> 
> Testing
> -------
> 
> make check
> Tested with /r/55449/
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message