mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 55509: Validate the StatusUpdate UUID in Master::statusUpdate.
Date Fri, 13 Jan 2017 17:22:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55509/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-6920
    https://issues.apache.org/jira/browse/MESOS-6920


Repository: mesos


Description
-------

To be consistent with Master::statusUpdateAcknowledgement(), validate
that the UUID in the StatusUpdate message is acceptable to the
UUID::fromBytes() parser.


Diffs
-----

  3rdparty/stout/include/stout/os/linux.hpp 68b4090aa5e6f23609c487128d91301755ae0e46 
  docs/contributors.yaml d2b686c9c15782eefeed3376dc84edba22968745 
  src/linux/ns.hpp da43266ba67f76c9ca856584a540794062097691 
  src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040 
  src/slave/containerizer/mesos/containerizer.cpp 4d2b4344e9698aed6ef0d49bb56d9292f2c3703b

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp f6f2bfe1d5d3c113036ad44a480f97bbb462a269

  support/apply-reviews.py c77b4c2b2d7a3d5e74e225403e71a84e23a9a1e7 

Diff: https://reviews.apache.org/r/55509/diff/


Testing
-------

Make check (Fedora 25). Manual testing with a handmade StatusUpdate message.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message