mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 55461: Made resource reservation validation multi-role aware.
Date Fri, 13 Jan 2017 15:50:38 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 13, 2017, 4:50 p.m.)

Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.


Addressed review comment from guoger.

Bugs: MESOS-6730

Repository: mesos


This updates the resource reservation validation for frameworks which
can have multiple roles. During a deprecation period 'FrameworkInfo'
will have fields for both 'role' and 'roles', however the validation
function works with just an optional set of roles. Here an empty set
captures the previous semantics of either having an empty 'role' field
or 'role' set as '*'. This forces the callers to properly construct a
set of framework roles from the available information. An optional set
is used in order to accommodate callers which have no information
about the framework's roles, and ultimately disables validation taking
that information into account.

Diffs (updated)

  src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040 
  src/master/validation.hpp 57e81779ff7444904c2ad7bad33aaf9167b98d05 
  src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f 
  src/tests/master_validation_tests.cpp e5d55e03648cb218d42adc594d6fa7d40ea9bcbb 



make check


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message