-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55489/#review161500
-----------------------------------------------------------
support/mesos-tidy.sh (line 19)
<https://reviews.apache.org/r/55489/#comment232803>
Should we also set `pipefail`?
support/mesos-tidy.sh
<https://reviews.apache.org/r/55489/#comment232804>
It seems something like this would still be useful for the cmake build so callers could
pass extra configuration flags (e.g., of the form `-DENABLE_DEBUG=ON`).
support/mesos-tidy/entrypoint.sh (line 19)
<https://reviews.apache.org/r/55489/#comment232802>
Should we also set `pipefail`?
support/mesos-tidy/entrypoint.sh (line 27)
<https://reviews.apache.org/r/55489/#comment232807>
Left over debug tooling?
support/mesos-tidy/entrypoint.sh (line 33)
<https://reviews.apache.org/r/55489/#comment232805>
I don't think the folks interested in cmake would ever see this comment here. We should
create tickets and link them here.
support/mesos-tidy/entrypoint.sh (line 47)
<https://reviews.apache.org/r/55489/#comment232806>
Dito.
- Benjamin Bannier
On Jan. 13, 2017, 10:59 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55489/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 10:59 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used CMake to generate the compilation database instead.
>
>
> Diffs
> -----
>
> support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7
> support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
> support/mesos-tidy/entrypoint.sh 72872375f3e5ad19bc75949f9e3db14d6068f9b6
>
> Diff: https://reviews.apache.org/r/55489/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
|