mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 54793: Prevented task launches that reuse unreachable task IDs.
Date Fri, 13 Jan 2017 00:42:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54793/
-----------------------------------------------------------

(Updated Jan. 13, 2017, 12:42 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Address review comments.


Bugs: MESOS-6805
    https://issues.apache.org/jira/browse/MESOS-6805


Repository: mesos


Description
-------

The master keeps an in-memory cache of task IDs that have recently been
marked unreachable. The master now consults this cache to reject task
launch attempts that reuse one of these recently unreachable task IDs
(such tasks are not terminal and may resume running in the future). This
check is not complete (we won't detect all cases in which unreachable
task IDs are reused), but preventing this from happening in the common
case seems worth doing. See MESOS-6785 for details.


Diffs (updated)
-----

  src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f 
  src/tests/master_validation_tests.cpp e5d55e03648cb218d42adc594d6fa7d40ea9bcbb 

Diff: https://reviews.apache.org/r/54793/diff/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message