mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 55449: Validate executor IDs in master validation.
Date Fri, 13 Jan 2017 00:31:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55449/#review161467
-----------------------------------------------------------




src/tests/master_validation_tests.cpp (line 1751)
<https://reviews.apache.org/r/55449/#comment232761>

    I had the impression that spaces in IDs were also bad...
    
    I'm hoping we don't use the sandbox path in a shell anywhere anymore.


- Joseph Wu


On Jan. 12, 2017, 1:47 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55449/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2017, 1:47 a.m.)
> 
> 
> Review request for mesos, James Peach and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Validate executor IDs in master validation.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp 57e81779ff7444904c2ad7bad33aaf9167b98d05 
>   src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f 
>   src/tests/master_validation_tests.cpp e5d55e03648cb218d42adc594d6fa7d40ea9bcbb 
> 
> Diff: https://reviews.apache.org/r/55449/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message