mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 55435: Windows: Fixed the locale guard in jsonify.hpp.
Date Thu, 12 Jan 2017 23:14:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55435/
-----------------------------------------------------------

(Updated Jan. 12, 2017, 3:14 p.m.)


Review request for mesos, Alexander Rojas, Daniel Pravat, Alex Clemmer, and Michael Park.


Changes
-------

Improved destruction of locale guard and added comments.


Repository: mesos


Description (updated)
-------

Changing locales in Windows is mainly accomplished via `setlocale`,
which takes a bit mask (with constants named slightly differently
than in the POSIX headers) and a `char*`.

This also adds a comment to the locale guard.


Diffs (updated)
-----

  3rdparty/stout/include/stout/jsonify.hpp 3c48046e087de2a66139a31449327fd94c149371 

Diff: https://reviews.apache.org/r/55435/diff/


Testing
-------

Windows:

msbuild Mesos.sln /p:PreferredToolArchitecture=x64 /m /t:stout-tests
3rdparty\stout\tests\Debug\stout-tests.exe --gtest_filter="*Json*"


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message