mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Review Request 55454: Ensured zero health check timeout means infinite timeout.
Date Thu, 12 Jan 2017 13:19:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55454/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone.


Bugs: MESOS-6908
    https://issues.apache.org/jira/browse/MESOS-6908


Repository: mesos


Description
-------

Prior to this patch, zero health check timeout was interpreted
literally, which is not very helpful since a health check did not
even get a chance to finish. This patch fixes this behaviour by
interpreting zero as `Duration::max()` effectively rendering the
timeout infinite.


Diffs
-----

  include/mesos/mesos.proto ab68ff85c4af5d254779b30a7f27eda9fcb790eb 
  include/mesos/v1/mesos.proto caefa239be6ead10b9a5fc91ba120ea9c8775313 
  src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26 

Diff: https://reviews.apache.org/r/55454/diff/


Testing
-------

make check


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message