mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 55435: Windows: Fixed the locale guard in jsonify.hpp.
Date Thu, 12 Jan 2017 10:32:19 GMT


> On Jan. 12, 2017, 1:50 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [55435, 55029, 55028, 55026, 55025, 55024, 55023, 55022]
> > 
> > Failed command: python support/apply-reviews.py -n -r 55022
> > 
> > Error:
> > Traceback (most recent call last):
> >   File "support/apply-reviews.py", line 349, in <module>
> >     reviewboard()
> >   File "support/apply-reviews.py", line 328, in reviewboard
> >     apply_review()
> >   File "support/apply-reviews.py", line 121, in apply_review
> >     fetch_patch()
> >   File "support/apply-reviews.py", line 150, in fetch_patch
> >     r = urllib2.urlopen(patch_url(), context=ssl_create_default_context())
> >   File "support/apply-reviews.py", line 131, in ssl_create_default_context
> >     context = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
> > AttributeError: 'module' object has no attribute 'SSLContext'
> > Error in atexit._run_exitfuncs:
> > Traceback (most recent call last):
> >   File "/usr/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
> >     func(*targs, **kargs)
> >   File "support/apply-reviews.py", line 119, in <lambda>
> >     atexit.register(lambda: os.remove('%s.patch' % patch_id()))
> > OSError: [Errno 2] No such file or directory: '55022.patch'
> > Error in sys.exitfunc:
> > Traceback (most recent call last):
> >   File "/usr/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
> >     func(*targs, **kargs)
> >   File "support/apply-reviews.py", line 119, in <lambda>
> >     atexit.register(lambda: os.remove('%s.patch' % patch_id()))
> > OSError: [Errno 2] No such file or directory: '55022.patch'
> > 
> > Full log: https://builds.apache.org/job/Mesos-Reviewbot/16691/console

Looks like http://stackoverflow.com/questions/28228214/ssl-module-object-has-no-attribute-sslcontext
and I can see that we're getting Python 2.7.6 on that particular box... Maybe we need a more
strict
constraint on the ubuntu version or something on Reviewbot...


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55435/#review161363
-----------------------------------------------------------


On Jan. 11, 2017, 4:56 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55435/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2017, 4:56 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Daniel Pravat, Alex Clemmer, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changing locales in Windows is mainly accomplished via `setlocale`,
> which takes a bit mask (with constants named slightly differently
> than in the POSIX headers) and a `char*`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/jsonify.hpp 3c48046e087de2a66139a31449327fd94c149371 
> 
> Diff: https://reviews.apache.org/r/55435/diff/
> 
> 
> Testing
> -------
> 
> Windows:
> 
> msbuild Mesos.sln /p:PreferredToolArchitecture=x64 /m /t:stout-tests
> 3rdparty\stout\tests\Debug\stout-tests.exe --gtest_filter="*Json*"
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message