mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 55445: Augmented a fault_tolerance_test to cover update of role.
Date Thu, 12 Jan 2017 09:49:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55445/#review161362
-----------------------------------------------------------


Ship it!




It would be great to add sth in `Testing Done` section to verify that the test cases you updated
still works well.

- Guangya Liu


On 一月 12, 2017, 8:56 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55445/
> -----------------------------------------------------------
> 
> (Updated 一月 12, 2017, 8:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In currently implementation, update of role during framework failover
> is ignored. This behavior should be reflected in test.
> 
> 
> Diffs
> -----
> 
>   src/tests/fault_tolerance_tests.cpp 05937a917a2c175aa53b52488febb7cfd8400a13 
> 
> Diff: https://reviews.apache.org/r/55445/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message