-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55242/#review161344
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55238, 55239, 55240, 55241, 55242]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 12, 2017, 12:29 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55242/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 12:29 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
>
>
> Bugs: MESOS-6862
> https://issues.apache.org/jira/browse/MESOS-6862
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reimplement os::chown() to use fts(3) rather than sometimes spawning
> chown(1). This removes the use of the shell and the corresponding
> need to sanitize path arguments. It also enables us to provide
> consistent handling of symbolic links for the recursive and
> non-recursive cases. We ensure that symlinks are never followed
> and that we always change the ownership of the link itself, not
> its referent.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/chown.hpp c82e2e574019c5ee5f17ea105a6d225006388a45
> 3rdparty/stout/include/stout/os/posix/stat.hpp 1ab20e75fc18b336162b62e2f4f23b68f6685183
> 3rdparty/stout/tests/os_tests.cpp 30735e28a26ff713469711d63538676ed4e327d9
>
> Diff: https://reviews.apache.org/r/55242/diff/
>
>
> Testing
> -------
>
> `sudo make check` (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>
|