mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 55239: Stop using os::system to extract fetcher archives.
Date Wed, 11 Jan 2017 16:10:12 GMT


> On Jan. 11, 2017, 9:55 a.m., Jiang Yan Xu wrote:
> > src/launcher/fetcher.cpp, line 91
> > <https://reviews.apache.org/r/55239/diff/1/?file=1598134#file1598134line91>
> >
> >     `status()` is not guaranteed to be ready, this could crash the fetcher process.

This implicitly awaits the future. It would crash if the future failed or is discarded, which
AFAIK can't happen here.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55239/#review161197
-----------------------------------------------------------


On Jan. 6, 2017, 1:13 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55239/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2017, 1:13 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6862
>     https://issues.apache.org/jira/browse/MESOS-6862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stop using os::system to extract fetcher archives.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f 
> 
> Diff: https://reviews.apache.org/r/55239/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message