mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 55240: Stop using os::system to copy local files.
Date Wed, 11 Jan 2017 16:09:09 GMT


> On Jan. 11, 2017, 9:57 a.m., Jiang Yan Xu wrote:
> > I commented on /r/55239/ about the `_spawn()` helper. We could just use `os::spawn()`
directly here.

The `_spawn` helper is still an improvement here since it gets the error message right. If
we remove the helper in the previous review, I guess we can still use `spawn` here and format
the error correctly.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55240/#review161198
-----------------------------------------------------------


On Jan. 6, 2017, 1:15 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55240/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2017, 1:15 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6862
>     https://issues.apache.org/jira/browse/MESOS-6862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stop using os::system to copy local files.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f 
> 
> Diff: https://reviews.apache.org/r/55240/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message