mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 55022: Windows: Cause errors to be correctly reported in `io::read`.
Date Wed, 11 Jan 2017 02:09:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55022/#review161170
-----------------------------------------------------------



The change LGTM, but it might need a rebase due to some changes BenH made to the same file.
 And MPark will also be committing a change to this file soon (related to `io::peek`).

A few things to note:

* Why not make the same changes to `io::write`?
* Remove the TODO that BenH left: `TODO(benh): Confirm that `os::strerror` does the right
thing for `error` on Windows.`

- Joseph Wu


On Dec. 24, 2016, 1:31 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55022/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2016, 1:31 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph
Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Cause errors to be correctly reported in `io::read`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73 
> 
> Diff: https://reviews.apache.org/r/55022/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message