> On Jan. 3, 2017, 10:51 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 5512
> > <https://reviews.apache.org/r/54232/diff/2/?file=1574478#file1574478line5512>
> >
> > inline this?
To me, using a separate function was more readable than writing the logic inline. Happy to
change it if you disagree, though.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54232/#review160439
-----------------------------------------------------------
On Jan. 10, 2017, 10:32 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54232/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2017, 10:32 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6602
> https://issues.apache.org/jira/browse/MESOS-6602
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, if a framework completed (e.g., due to a teardown operation
> or framework shutdown), any framework tasks running on partitioned
> agents would not be shutdown when the agent re-registered. For tasks
> that are not partition-aware, the task would be shutdown on agent
> re-registration anyway. But for partition-aware tasks, this could lead
> to orphan tasks.
>
> Fix this by changing the master to shutdown such tasks when the agent
> reregisters.
>
> Note that if the master fails over between the time the framework
> completes and a partitioned agent re-registers, any framework tasks
> running on the agent will NOT be shutdown. This is a known bug; fixing
> it requires persisting the framework shutdown operation to the registry
> (MESOS-1719).
>
>
> Diffs
> -----
>
> src/master/master.hpp 368ee1d5e97784fa54e0f141906405ee8f104317
> src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
> src/tests/partition_tests.cpp 72013d1bfee275c6f3cb90173f0c408d55e0bc5d
>
> Diff: https://reviews.apache.org/r/54232/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
|