mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 55296: Used `jsonify` in `operator<<` for `JSON::*` to reduce duplicate code.
Date Tue, 10 Jan 2017 00:36:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55296/
-----------------------------------------------------------

(Updated Jan. 9, 2017, 4:36 p.m.)


Review request for mesos, Alexander Rojas and Joris Van Remoortere.


Changes
-------

Addressed arojas' comment.


Repository: mesos


Description (updated)
-------

The printing logic for `json.hpp` and `jsonify.hpp` are currently
duplicated. We can reduce this duplication by leveraging `jsonify` for
the implementation of `operator<<` for `JSON::*`. Since `JSON::Value`s
are not generally used for printing, there should be no performance
concerns here.


Diffs (updated)
-----

  3rdparty/stout/include/stout/json.hpp 62ce15274677112d142a3c829b4a9f06258c9e2c 

Diff: https://reviews.apache.org/r/55296/diff/


Testing
-------


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message