mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 55355: Fixed an FD leak in the IO switchboard.
Date Mon, 09 Jan 2017 20:35:18 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 9, 2017, 8:35 p.m.)

Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, Joseph Wu,
and Kevin Klues.

Repository: mesos


Previously, the IO switchboard could leak file descriptors
because it held a reference to its server socket within the
socket's accept loop. This patch explicitly discards the
future containing this reference to eliminate the leak.


  src/slave/containerizer/mesos/io/switchboard.cpp 67c51678e87389ab08a81fe4832cffd3d83bdae9



`bin/ --gtest_repeat=-1 --gtest_filter="IOSwitchboardServerTest.AttachInput"`

and then simultaneously execute `sudo lsof -p PID_of_test_process | wc -l` repeatedly to ensure
that the number of open FDs is not increasing.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message