mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Review Request 55355: Fixed an FD leak in the IO switchboard.
Date Mon, 09 Jan 2017 20:35:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55355/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, Joseph Wu,
and Kevin Klues.


Repository: mesos


Description
-------

Previously, the IO switchboard could leak file descriptors
because it held a reference to its server socket within the
socket's accept loop. This patch explicitly discards the
future containing this reference to eliminate the leak.


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 67c51678e87389ab08a81fe4832cffd3d83bdae9


Diff: https://reviews.apache.org/r/55355/diff/


Testing
-------

Run:
`bin/mesos-tests.sh --gtest_repeat=-1 --gtest_filter="IOSwitchboardServerTest.AttachInput"`

and then simultaneously execute `sudo lsof -p PID_of_test_process | wc -l` repeatedly to ensure
that the number of open FDs is not increasing.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message