mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.
Date Mon, 09 Jan 2017 20:24:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review160958
-----------------------------------------------------------



What is the reason for this change? It seems much more intuitive for me to have a simple build
directive that we simply remove once of the rename is complete, compared to a custom install-hook
that creates a symlink.

- Kevin Klues


On Jan. 9, 2017, 8:02 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2017, 8:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael Park, Vinod
Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6772
>     https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> -------
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root      11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message