mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 55296: Used `jsonify` in `operator<<` for `JSON::*` to reduce duplicate code.
Date Mon, 09 Jan 2017 16:52:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55296/#review160902
-----------------------------------------------------------




3rdparty/stout/include/stout/json.hpp (line 679)
<https://reviews.apache.org/r/55296/#comment232146>

    This needs either UNREACHABLE() or to return stream to avoid warnings.


- Alexander Rojas


On Jan. 7, 2017, 11:02 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55296/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2017, 11:02 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The printing logic for `json.hpp` and `jsonify.hpp` are currently duplicated.
> We can reduce this duplication by leveraging `jsonify` for the implementation of `operator<<`
for `JSON::*`.
> Since `JSON::Value`s are not generally used for printing, there should be no performance
concerns here.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/json.hpp 62ce15274677112d142a3c829b4a9f06258c9e2c 
> 
> Diff: https://reviews.apache.org/r/55296/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message