mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 55339: Removed unsupported 'friend' declaration.
Date Mon, 09 Jan 2017 15:29:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55339/#review160895
-----------------------------------------------------------



Patch looks great!

Reviews applied: [55339]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 9, 2017, 1:43 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55339/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2017, 1:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Bugs: MESOS-6895
>     https://issues.apache.org/jira/browse/MESOS-6895
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The friend class declaration of nested, templated classes
> will raise an error when compiling with Clang.
> This is resolved by making the constructor of 'ControlFlow' public.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/loop.hpp 53f62439752a6eb7cf870022e4965c9261fc3ba6

> 
> Diff: https://reviews.apache.org/r/55339/diff/
> 
> 
> Testing
> -------
> 
> make check with
> ```
> $ clang --version
> Apple LLVM version 8.0.0 (clang-800.0.42.1)
> Target: x86_64-apple-darwin16.3.0
> ```
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message