mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Review Request 55339: Removed unsupported 'friend' declaration.
Date Mon, 09 Jan 2017 13:43:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55339/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Michael Park.


Bugs: MESOS-6895
    https://issues.apache.org/jira/browse/MESOS-6895


Repository: mesos


Description
-------

The friend class declaration of nested, templated classes
will raise an error when compiling with Clang.
This is resolved by making the constructor of 'ControlFlow' public.


Diffs
-----

  3rdparty/libprocess/include/process/loop.hpp 53f62439752a6eb7cf870022e4965c9261fc3ba6 

Diff: https://reviews.apache.org/r/55339/diff/


Testing
-------

make check with
```
$ clang --version
Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin16.3.0
```


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message