mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 54638: Added agent flags '--oci_discovery' and '--oci_discovery_prefix'.
Date Mon, 09 Jan 2017 09:11:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54638/#review160874
-----------------------------------------------------------




src/slave/flags.hpp (lines 60 - 61)
<https://reviews.apache.org/r/54638/#comment232125>

    As you may already observe, these two flags may be confusing. We may either find another
name, or document them in the documentation patch later.



src/slave/flags.cpp (line 173)
<https://reviews.apache.org/r/54638/#comment232124>

    What elas types we might have?


- Gilbert Song


On Jan. 3, 2017, 6:18 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54638/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2017, 6:18 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent flags '--oci_discovery' and '--oci_discovery_prefix'.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md e4beb2d5a72f1c5f59b2e40f4984cc60b8437d9d 
>   src/slave/flags.hpp 6ac0d45072157f6741b96266886a326e9337c153 
>   src/slave/flags.cpp 1eccea920338032173be4df6c374ec50dbd2eaf3 
> 
> Diff: https://reviews.apache.org/r/54638/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message