mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55302: Improved OneWayPartitionTest.MasterToSlave.
Date Mon, 09 Jan 2017 02:24:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55302/#review160854
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/partition_tests.cpp (line 2523)
<https://reviews.apache.org/r/55302/#comment232085>

    s/receives/until it receives/ ?


- Vinod Kone


On Jan. 7, 2017, 9:12 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55302/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2017, 9:12 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6286
>     https://issues.apache.org/jira/browse/MESOS-6286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix theoretical test flakiness (unlikely to be a problem in practice),
> add more test expections, and cleanup code.
> 
> 
> Diffs
> -----
> 
>   src/tests/partition_tests.cpp 3afdbba13a9753edce17b24ff6d1898d3cc6de62 
> 
> Diff: https://reviews.apache.org/r/55302/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message