mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55157: Fixed a bug in the default executor around not committing suicide.
Date Mon, 09 Jan 2017 02:10:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55157/#review160849
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/default_executor.cpp (lines 663 - 683)
<https://reviews.apache.org/r/55157/#comment232083>

    How about
    
    ```
    // Check to see if the executor needs to shutdown.
    
    // If the executor is already in the process of shutting down, return.
    if (shuttingDown) {
      return;
    }
    
    // If there are no active containers, shutdown the executor.
    if (containers.empty()) {
      shutdown();
      return;
    }
    
    // If this container exited with non-zero status, kill all the other containers,
    // per the default policy.
    if (taskState == TASK_FAILED) {
    
      // TODO(Anand): ...
      shutdown();
    }
    
    ```


- Vinod Kone


On Jan. 4, 2017, 12:38 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55157/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2017, 12:38 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6848
>     https://issues.apache.org/jira/browse/MESOS-6848
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This bug is only observed when the task group contains a single task.
> The default executor was not committing suicide when this single task
> used to exit with a non-zero status code as per the default restart
> policy.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp fd9963996c82461b60888397989e309d51b60aaa 
>   src/tests/default_executor_tests.cpp 340e8c8b36a6a3cc6e5bae021e19dfa7a54852c3 
> 
> Diff: https://reviews.apache.org/r/55157/diff/
> 
> 
> Testing
> -------
> 
> make check + added a test
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message