mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 54573: Updated metrics counter during scheduler api calls.
Date Sun, 08 Jan 2017 22:13:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54573/#review160844
-----------------------------------------------------------




src/master/master.cpp (line 3639)
<https://reviews.apache.org/r/54573/#comment232081>

    Will accept calls to non V1 http API also increase this counter? If so, we should handle
it elsewhere (i.e. in `src/master/http.cpp` so all metrics handling for V1 http api is happening
in the same file)?
    
    This seems to apply to all metrics incremental in this file.


- Zhitao Li


On Dec. 9, 2016, 4:40 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54573/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2016, 4:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Zhitao Li.
> 
> 
> Bugs: MESOS-6082
>     https://issues.apache.org/jira/browse/MESOS-6082
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated metrics counter during  scheduler api calls.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f 
>   src/master/master.cpp 67f32229470da4cf7953881d1c5dcb99393002de 
> 
> Diff: https://reviews.apache.org/r/54573/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message