mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Review Request 55252: Added `_getRoles()` to extract some logic of `getRoles()`.
Date Fri, 06 Jan 2017 06:43:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55252/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.


Bugs: MESOS-6855
    https://issues.apache.org/jira/browse/MESOS-6855


Repository: mesos


Description
-------

To add 'roles' section in `/state` endpoint, some of the logic in
`getRoles()` could be reused. This patch added `_getRoles()` method
to extract that logic away from `getRoles()`.


Diffs
-----

  src/master/http.cpp 75dcd6199dbfcca6260baed49b838a45312bb667 
  src/master/master.hpp 57fc6e6f2995078df80f0aa52707727db802ede0 

Diff: https://reviews.apache.org/r/55252/diff/


Testing
-------


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message