mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 55005: CMake: renamed `process_tests` to `libprocess-tests` to match autotools.
Date Fri, 06 Jan 2017 00:00:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55005/#review160650
-----------------------------------------------------------




3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake (line 20)
<https://reviews.apache.org/r/55005/#comment231797>

    As I said in response to Till's comment, I think it is better to call it `process-tests`.
We specifically call it this because on Windows, there is no `libprocess`. There is only `process.lib`.


- Alex Clemmer


On Dec. 23, 2016, 2:09 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55005/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2016, 2:09 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See https://reviews.apache.org/r/55006/.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9817426c3c924c7cd988d5bf4fd41b6a2fd4962a

>   3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623

> 
> Diff: https://reviews.apache.org/r/55005/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message