mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 55226: Cleaned up std::string usage in libprocess.
Date Thu, 05 Jan 2017 20:04:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55226/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

Avoid redundant initialization to empty string, use `char` overloads
instead for single-character string literals.

Spotted with clang-tidy.


Diffs
-----

  3rdparty/libprocess/src/http.cpp 97d1424be20e217401519c2bee79857bcf087023 
  3rdparty/libprocess/src/tests/io_tests.cpp b9825e8633f64c23e4b1ea904537cdc8da64ed5b 

Diff: https://reviews.apache.org/r/55226/diff/


Testing
-------

`make check` on OSX and Linux, plus internal CI.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message