mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 55220: Cleaned up std::string usage in mesos.
Date Thu, 05 Jan 2017 19:06:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55220/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

Avoid redundant initialization to empty string, use `char` overloads
instead for single-character string literals.

Spotted with clang-tidy.


Diffs
-----

  src/common/resources.cpp 7dbeefc8fc159f28dc1542ad6a761213c65ff226 
  src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47 
  src/slave/containerizer/fetcher.cpp 94cfa0e33adc622d77a75e256fb52fc75d3db18a 
  src/zookeeper/zookeeper.cpp e105377ed0ceba22b03c27ab1209e7a96c284066 

Diff: https://reviews.apache.org/r/55220/diff/


Testing
-------

`make check` on OSX and Linux, plus internal CI.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message