mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 55021: Added a framework capabilities struct.
Date Thu, 05 Jan 2017 15:30:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55021/#review160591
-----------------------------------------------------------




src/common/protobuf_utils.hpp (line 44)
<https://reviews.apache.org/r/55021/#comment231723>

    Do not use `using` declarations in header files. Instead use the fully qualified name.



src/common/protobuf_utils.hpp (line 210)
<https://reviews.apache.org/r/55021/#comment231724>

    `Capabilities() = default;`



src/common/protobuf_utils.hpp (line 214)
<https://reviews.apache.org/r/55021/#comment231726>

    Nit: `Framework::Capability::Type` is probably smaller than the size of a ref, so you
could just copy the loop variable here.


- Benjamin Bannier


On Jan. 5, 2017, 1:19 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55021/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 1:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Master, agent and allocator structs could use this stuct to easily
> deal with Framework Capabilities.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp f225bb0f5196f7f4b12be25828361a38e1d42e60 
>   src/tests/protobuf_utils_tests.cpp 4ce952a7d3901a4362aa69f199b135b53d14a723 
> 
> Diff: https://reviews.apache.org/r/55021/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message