mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 53299: Fixed memory leak in implementation of Future<T>::after().
Date Wed, 04 Jan 2017 14:58:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53299/
-----------------------------------------------------------

(Updated Jan. 4, 2017, 3:58 p.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Joris Van Remoortere.


Bugs: MESOS-6484
    https://issues.apache.org/jira/browse/MESOS-6484


Repository: mesos


Description
-------

Removes a reference counted pointer that futures kept to themselves
when using the method `Future<T>::after()`.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/future.hpp 26bf5851f6562cd73aa4938b3308639144657044

  3rdparty/libprocess/src/tests/future_tests.cpp 7c411c7be1849119fe0b070622dbe4488fa11b7a


Diff: https://reviews.apache.org/r/53299/diff/


Testing (updated)
-------

```bash
make check
# Left to run for at least 3_000_000 iterations.
./3rdparty/libprocess/libprocess-tests --gtest_filter="FutureTest.After3" --gtest_repeat=-1
--gtest_break_on_failure
```


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message