mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54216: Fixed unsufficient root privileges check by geteuid().
Date Wed, 04 Jan 2017 12:12:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54216/#review160483
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54211, 54212, 54213, 54214, 54816, 54215, 50871, 54216]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 3, 2017, 10:47 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54216/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2017, 10:47 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, James DeFelice, and Jie
Yu.
> 
> 
> Bugs: MESOS-6504
>     https://issues.apache.org/jira/browse/MESOS-6504
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We should check the root privileges by using the effective user
> id, instead of comparing os::user() to 'root'.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 74ab1fda4587d887342f8e63b3a38d450d9c6941

>   src/slave/containerizer/mesos/isolators/gpu/volume.cpp 478752f372200b79cb3bd1e1c0f254f529930b78

>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp c92c6c7174421158b9190ed0bfb00c1c97ef0f7b

>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 94dac40a12b6fd2e7d9733444d84763c77785402

>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp a6e6c8b84adadc24b915b45533d1789f8de758dd

> 
> Diff: https://reviews.apache.org/r/54216/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message