mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 54216: Fixed unsufficient root privileges check by geteuid().
Date Tue, 03 Jan 2017 22:47:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54216/
-----------------------------------------------------------

(Updated Jan. 3, 2017, 2:47 p.m.)


Review request for mesos, Avinash sridharan, Artem Harutyunyan, James DeFelice, and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-6504
    https://issues.apache.org/jira/browse/MESOS-6504


Repository: mesos


Description
-------

We should check the root privileges by using the effective user
id, instead of comparing os::user() to 'root'.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 74ab1fda4587d887342f8e63b3a38d450d9c6941

  src/slave/containerizer/mesos/isolators/gpu/volume.cpp 478752f372200b79cb3bd1e1c0f254f529930b78

  src/slave/containerizer/mesos/provisioner/backends/aufs.cpp c92c6c7174421158b9190ed0bfb00c1c97ef0f7b

  src/slave/containerizer/mesos/provisioner/backends/bind.cpp 94dac40a12b6fd2e7d9733444d84763c77785402

  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp a6e6c8b84adadc24b915b45533d1789f8de758dd


Diff: https://reviews.apache.org/r/54216/diff/


Testing
-------

make check


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message