mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 51052: Made mesos-docker-execute understand cgroups_enable_cfs.
Date Tue, 03 Jan 2017 21:16:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/
-----------------------------------------------------------

(Updated Jan. 3, 2017, 9:16 p.m.)


Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.


Changes
-------

Redo this patch on top of r/54821


Summary (updated)
-----------------

Made mesos-docker-execute understand cgroups_enable_cfs.


Bugs: MESOS-6134
    https://issues.apache.org/jira/browse/MESOS-6134


Repository: mesos


Description (updated)
-------

This fixed cpu quota for command executor (which runs outside
of the docker container) by ensuing --cpu-quota flag to docker
run.


Diffs (updated)
-----

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
  src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47 
  src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 
  src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7 
  src/slave/containerizer/docker.cpp 7a8a7271b54af0b4dcdae7a2aa8a90a8a7d05fd6 
  src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd 

Diff: https://reviews.apache.org/r/51052/diff/


Testing
-------

I am now able to make docker containers launched through mesos-execute have a cpu quota.

Also making sure `make check` still works on mac os for the linux only flag.


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message