mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Pravat <dpra...@outlook.com>
Subject Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.
Date Tue, 03 Jan 2017 18:43:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55023/#review160410
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (line 1604)
<https://reviews.apache.org/r/55023/#comment231548>

    This change is sufficient to fix the problem. Otherwise the user must add flags.launcher_dir
to the path.



src/slave/containerizer/mesos/containerizer.cpp (line 1614)
<https://reviews.apache.org/r/55023/#comment231549>

    Not necessary to run cmd.exe (arg0) just to start mesos_containerizer.


- Daniel Pravat


On Dec. 24, 2016, 10:02 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55023/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2016, 10:02 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph
Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently in `MesosContainerizerProcess::_launch`, we are passing a
> malformatted shell command to the launcher. This causes the
> containerizer process to crash immediately upon invocation in all
> executor tests.
> 
> This commit will fix this command.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp d9d5619e45ae1199fc91878f17a33b5647f48305

> 
> Diff: https://reviews.apache.org/r/55023/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message