mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <>
Subject Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.
Date Tue, 03 Jan 2017 17:42:13 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 3, 2017, 5:42 p.m.)

Review request for mesos, Xiaojian Huang, haosdent huang, and Jie Yu.


Intent nit fixes.

Bugs: MESOS-6808

Repository: mesos


This patch creates a wrapper struct for all recognizable docker cli
options, and separate logic of creating these options to a different
common function.

This also enables us to overcome gmock's 10 argument limit.

No logic change happens in this refactoring patch.

Diffs (updated)

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
  src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47 
  src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7 
  src/slave/containerizer/docker.cpp 7a8a7271b54af0b4dcdae7a2aa8a90a8a7d05fd6 
  src/tests/containerizer/docker_containerizer_tests.cpp 4e3b67bbb989f9084dfdf4970839956dcb0caa0e

  src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd 
  src/tests/mock_docker.hpp 829a760d54ad8c7b88256ae5df4c88c9fb18df71 
  src/tests/mock_docker.cpp 02b6065a01e7e52b0edb38676dfb1bb475584502 



`make check` with ROOT and DOCKER filter.


Zhitao Li

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message