From reviews-return-51928-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Dec 6 16:26:23 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E5C5E19CB3 for ; Tue, 6 Dec 2016 16:26:22 +0000 (UTC) Received: (qmail 40430 invoked by uid 500); 6 Dec 2016 16:26:22 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 40406 invoked by uid 500); 6 Dec 2016 16:26:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 40388 invoked by uid 99); 6 Dec 2016 16:26:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 16:26:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 488F72CAF72; Tue, 6 Dec 2016 16:26:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6395653944814549531==" MIME-Version: 1.0 Subject: Re: Review Request 52379: Added agent flag '--oci_store_dir'. From: Avinash sridharan To: Jie Yu Cc: Avinash sridharan , Qian Zhang , mesos Date: Tue, 06 Dec 2016 16:26:22 -0000 Message-ID: <20161206162622.1678.57601@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Avinash sridharan X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52379/ X-Sender: Avinash sridharan References: <20161203015119.1642.16595@reviews.apache.org> In-Reply-To: <20161203015119.1642.16595@reviews.apache.org> Reply-To: Avinash sridharan X-ReviewRequest-Repository: mesos --===============6395653944814549531== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52379/#review158169 ----------------------------------------------------------- docs/configuration.md (line 1606) Just checking: Isn't the `configuration.md` auto-generated? https://issues.apache.org/jira/browse/MESOS-4298 docs/configuration.md (line 1609) Directory in which the OCI provisioner will store images. src/slave/flags.cpp (line 167) Directory in which the OCI provisioner stores images. - Avinash sridharan On Dec. 3, 2016, 1:51 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52379/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2016, 1:51 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6681 > https://issues.apache.org/jira/browse/MESOS-6681 > > > Repository: mesos > > > Description > ------- > > Added agent flag '--oci_store_dir'. > > > Diffs > ----- > > docs/configuration.md efe3e9bd9d203a7ba44adf4ead24f14b8b577637 > docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded > docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b > src/slave/flags.hpp c6c3197bbf30ec617751f4a1a34914c0f0e29eb5 > src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 > src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f > > Diff: https://reviews.apache.org/r/52379/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > > --===============6395653944814549531==--