From reviews-return-51921-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Dec 6 14:15:17 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EDDDE19783 for ; Tue, 6 Dec 2016 14:15:16 +0000 (UTC) Received: (qmail 15815 invoked by uid 500); 6 Dec 2016 14:15:16 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 15787 invoked by uid 500); 6 Dec 2016 14:15:16 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 15767 invoked by uid 99); 6 Dec 2016 14:15:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 14:15:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 615352D9010; Tue, 6 Dec 2016 14:15:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4071817657908589353==" MIME-Version: 1.0 Subject: Re: Review Request 54381: Adds authorization support when attaching containers input/output. From: Alexander Rojas To: Adam B , Kevin Klues , Vinod Kone Cc: Mesos ReviewBot , Alexander Rojas , mesos Date: Tue, 06 Dec 2016 14:15:16 -0000 Message-ID: <20161206141516.1680.27973@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rojas X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54381/ X-Sender: Alexander Rojas References: <20161205161908.28536.53338@reviews.apache.org> In-Reply-To: <20161205161908.28536.53338@reviews.apache.org> Reply-To: Alexander Rojas X-ReviewRequest-Repository: mesos --===============4071817657908589353== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54381/ ----------------------------------------------------------- (Updated Dec. 6, 2016, 3:15 p.m.) Review request for mesos, Adam B, Kevin Klues, and Vinod Kone. Repository: mesos Description ------- Introduces authorization support for the newly introduced debug API calls: `AttachContainerInput` and `AttachContainerOutput`. Diffs (updated) ----- src/slave/http.cpp 91eebe117d3dc86dd5b1fd47156c01e147165cef src/slave/slave.hpp 4b94dff9c1f9f212f84984674268ef38b43d93bd src/slave/slave.cpp 7eb45036f49289972c0b706c3c8e2ed96553d279 src/tests/api_tests.cpp 7c70f284a9225ca23abc7049f48f3efba314b641 Diff: https://reviews.apache.org/r/54381/diff/ Testing ------- make check Thanks, Alexander Rojas --===============4071817657908589353==--