From reviews-return-51637-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Dec 3 00:06:30 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9BF8019241 for ; Sat, 3 Dec 2016 00:06:30 +0000 (UTC) Received: (qmail 16457 invoked by uid 500); 3 Dec 2016 00:06:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 16429 invoked by uid 500); 3 Dec 2016 00:06:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 16407 invoked by uid 99); 3 Dec 2016 00:06:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Dec 2016 00:06:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9D2012D9230; Sat, 3 Dec 2016 00:06:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0541476201686581449==" MIME-Version: 1.0 Subject: Re: Review Request 53552: Remove unnecessary use of `typename` causing Windows build break. From: Alex Clemmer To: Daniel Pravat , Joseph Wu Cc: Mesos ReviewBot , mesos , Alex Clemmer Date: Sat, 03 Dec 2016 00:06:29 -0000 Message-ID: <20161203000629.1641.7293@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alex Clemmer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53552/ X-Sender: Alex Clemmer References: <20161107191112.4232.49340@reviews.apache.org> In-Reply-To: <20161107191112.4232.49340@reviews.apache.org> Reply-To: Alex Clemmer X-ReviewRequest-Repository: mesos --===============0541476201686581449== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53552/ ----------------------------------------------------------- (Updated Dec. 3, 2016, 12:06 a.m.) Review request for mesos, Daniel Pravat and Joseph Wu. Repository: mesos Description ------- The use of `typename` in C++ is used to disambiguate between static members and dependent names that use the same symbol. For example, if you have some `T::iterator` and `T` happens to have a static member called iterator, it is necessary to add `typename T::iterator` to indicate that you want an iterator of `T` rather than to refer to teh static member `T::iterator`. In some cases we employ `typename` to make our intention clearer, even though it is not strictly speaking necessary. While normally a good habit, in the specific cases we change in this review, it causes MSVC to explode. This commit will remove these uses. Diffs (updated) ----- src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e Diff: https://reviews.apache.org/r/53552/diff/ Testing ------- Thanks, Alex Clemmer --===============0541476201686581449==--