mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 53691: Implemented some quota functionality tests.
Date Tue, 27 Dec 2016 18:50:44 GMT


> On Nov. 12, 2016, 8:01 a.m., Zhitao Li wrote:
> > src/tests/master_quota_tests.cpp, line 1723
> > <https://reviews.apache.org/r/53691/diff/1/?file=1562029#file1562029line1723>
> >
> >     @alexr, can you please advise what is the best way for the "alert and under
quota situation" check in your mind here?
> >     
> >     Given that there is only one agent, there is little we could do in such a case.

I think we should punt on this for now. Originally, we were thinking about providing some
sort of an explicit alert when allocation goes below its quota, but decided not to due to
difficulties in determining whether to alert or not during failover. I'd suggest we remove
this test and the corresponding TODO entry altogether for now.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53691/#review155772
-----------------------------------------------------------


On Dec. 27, 2016, 11:24 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53691/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2016, 11:24 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Xiaojian Huang.
> 
> 
> Bugs: MESOS-3982
>     https://issues.apache.org/jira/browse/MESOS-3982
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This implements some tests in previous todos for
> quota functionality.
> 
> The one for:
> 
> `Role quota is below its allocation (InverseOffer generation).`
> 
> does not seem be implementable right now, since
> hierarchical allocator does not send InverseOffer for
> quota yet.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 48be7406181646c8cc1d169b82a4a4ca71cdf03b 
> 
> Diff: https://reviews.apache.org/r/53691/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message