mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 55006: CMake: renamed test binaries to match autotools.
Date Tue, 27 Dec 2016 05:33:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55006/#review160136
-----------------------------------------------------------



Patch looks great!

Reviews applied: [55004, 55005, 55006]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 23, 2016, 2:22 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55006/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2016, 2:22 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently CMake generates test binaries named `stout_tests`,
> `process_tests` (underscores), and `mesos-tests` (dash).
> 
> We should simply follow the naming from autotools and call them
> `stout-tests`, `libprocess-tests`, and `mesos-tests`.
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt b034f1b88337b003d01450eadd262b9bc763545c 
>   support/windows-build.bat 4d1d8cd6cdcf6acac259b570387923fe385f4790 
> 
> Diff: https://reviews.apache.org/r/55006/diff/
> 
> 
> Testing
> -------
> 
> `cmake --build . -- -j 6`
> ```
> $ find . -name "*[-_]tests"
> ./3rdparty/libprocess/src/tests/libprocess-tests
> ./3rdparty/stout/tests/stout-tests
> ./src/mesos-tests
> ```
> 
> Built on Windows via `support/windows-build.bat`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message